codesankalp / dsalgo

MIT License
8 stars 24 forks source link

Implement tree traversal algorithms #21

Open Aryamanz29 opened 3 years ago

Aryamanz29 commented 3 years ago
milanj-1 commented 3 years ago

is code in C++ fine?

Aryamanz29 commented 3 years ago

is code in C++ fine?

No, You should code in python 3x.

Aryamanz29 commented 3 years ago

I could implement the same in python. Could you assign this issue to me? @Aryamanz29

Alright, I'm assigning this issue to you

Aryamanz29 commented 3 years ago

I could implement the same in python. Could you assign this issue to me? @Aryamanz29

Alright, I'm assigning this issue to you

First complete issue #23 then I'll assign this to you

Pratik-ahirrao commented 3 years ago

Can i work on this issue?

Aryamanz29 commented 3 years ago

@Aryamanz29 I was not working on #24 I was working on #23 and I have already raised a pull request for it. Could I work on this now?

I commented some changes in your PR about how to write test cases kindly check that.

shaonakundu commented 3 years ago

hey @Aryamanz29 I would like to write code for these three tree traversals, so will you assign me?

Aryamanz29 commented 3 years ago

hey @Aryamanz29 I would like to write code for these three tree traversals, so will you assign me?

@shaonakundu I'm assigning this issue to you.

shaonakundu commented 3 years ago

hey @Aryamanz29 I would like to write code for these three tree traversals, so will you assign me?

@shaonakundu I'm assigning this issue to you.

Thank you, so I can start from October 1 ?

Aryamanz29 commented 3 years ago

hey @Aryamanz29 I would like to write code for these three tree traversals, so will you assign me?

@shaonakundu I'm assigning this issue to you.

Thank you, so I can start from October 1 ?

It's up to you but one thing you should keep in mind if some other contributor creates PR for this issue before 1st Oct and it's passed by the maintainers then it will get merged.

shaonakundu commented 3 years ago

hey @Aryamanz29 I would like to write code for these three tree traversals, so will you assign me?

@shaonakundu I'm assigning this issue to you.

Thank you, so I can start from October 1 ?

It's up to you but one thing you should keep in mind if some other contributor creates PR for this issue before 1st Oct and it's passed by the maintainers then it will get merged.

Hey @Aryamanz29 I have created pull request for this python code at codesankalp/dsalgo repo, kindly review it. It was fun to contribute!! Also do suggest me if any changes required. Thanks in advance!