search

codesankalp / dsalgo

MIT License
8 stars 25 forks source link

Create traversals.py #32

Open Pratik-ahirrao opened 4 years ago

Pratik-ahirrao commented 4 years ago

Please keep label as hacktoberFest so that this commit can be counted as one of my 4 prs for hacktoberFest

Aryamanz29 commented 4 years ago

Please keep label as hacktoberFest so that this commit can be counted as one of my 4 prs for hacktoberFest

Write test cases for transversal.py. Test file should be named as "test_transversal.py" in dsalgo/tests and give a proper description of your PR.

Aryamanz29 commented 4 years ago

Please keep label as hacktoberFest so that this commit can be counted as one of my 4 prs for hacktoberFest

Add docstrings to specify - params of your functions & its description use pep -8 coding style (ref:- contributing.md) https://www.python.org/dev/peps/pep-0008/

codesankalp commented 4 years ago

@Pratik-ahirrao we will not approve your pull request until it's linked with an issue. Linking the issue with pull request is a must step. Also make the code changes as mentioned by @devkapilbansal