Linked list implementation in python

AnshMishra2001 commented 3 years ago

Description

Related Issue

Fixes #40

Type of Change:

Code

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)

Motivation and Context

How Has This Been Tested?

Checklist:

I read the CONTRIBUTING document before making this pull request
My code follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
My changes generate no new warnings
My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

devkapilbansal commented 3 years ago

Hi, @AnshMishra2001 please update the above comment with relevant details.

devkapilbansal commented 3 years ago

@codesankalp do we need this??

codesankalp commented 3 years ago

@AnshMishra2001 you need to add all the methods in the dsalgo/linked_list.py we don't need to re-implement the linked list. You haven't linked your issue with the pr also. Also, there are so many code-inline comments in your file. If you changed all the mentioned things within 2 days your pull request will be marked as valid and accepted else it will be considered as spam. See our contributing guidelines also.

devkapilbansal commented 3 years ago

@AnshMishra2001 are you working on this?

AnshMishra2001 commented 3 years ago

Yes! I'll complete it soon

AnshMishra2001 commented 3 years ago

Changes made in #40

codesankalp commented 3 years ago

Also squash your commits into one.

codesankalp commented 3 years ago

Please do the mentioned changes earlier and rebase your branch to avoid merge conflicts. If you are not working on this then tell me.

codesankalp / dsalgo