added addressing support to linked list

ravi5175 commented 3 years ago

Description

added support for node addressing in to_list() function
improved test case for enhanced usecases of Nodes.

Related Issues

Fixes #65

Type of Change:

Code
Quality Assurance
Documentation

Code/Quality Assurance Only

This change requires a documentation update (software upgrade on readme file)

How Has This Been Tested?

proper testing has been done in the test/linkedlist.ipynb file

Checklist:

[x] I read the CONTRIBUTING document before making this pull request
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] My change requires change to documentation
[x] I have updated documentation accordingly
[ ] I have updated the requirements file
[x] My changes generate no new warnings
[ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
[x] I have added tests to cover my changes
[x] All new and existing tests passed

Screenshots (if appropriate):

codesankalp commented 3 years ago

@ravi5175 @devkapilbansal will it be fine if we add address when converting the linkedlist to python list. because if a user needs conversion of linked list to python list then why we are providing the addresses also. So I think that we should add a new method for this like to_list_with_address Also in the linkedlist tests to list method is very important part for testing.

ravi5175 commented 3 years ago

@ravi5175 @devkapilbansal will it be fine if we add address when converting the linkedlist to python list. because if a user needs conversion of linked list to python list then why we are providing the addresses also. So I think that we should add a new method for this like to_list_with_address Also in the linkedlist tests to list method is very important part for testing.

@codesankalp it is still a list with a advanced usecase where a user can manually access the node located at some address, it can also be used used as a list with node values.

devkapilbansal commented 3 years ago

@ravi5175 change maintainers file to AUTHOR

Add Contributors and Authors there

There will be three section: Author Contributor Maintainer

devkapilbansal commented 3 years ago

@ravi5175 resolve conflicts and rebase your current branch with our master branch

Aryamanz29 commented 2 years ago

@ravi5175 Please do req changes, So that we move ahead with this PR Thanks

codesankalp / dsalgo