Closed devta108 closed 3 years ago
also this branch have conflicts so rebase your branch with master, try to squash commit into one
@nisheksharma after 2 days if you don't change anything then it will be marked as invalid.
@codesankalp review
@Aryamanz29 @17sushmita please review this pr.
Also, please follow commit message guidelines
Pinging @17sushmita for testing code locally before merge
Thanks @nisheksharma just one last request from my side. Change type to feature instead of file, as file is not a commit type defined in our guidelines
@nisheksharma rename your file to test_search
Done
Thanks @nisheksharma just one last request from my side. Change type to feature instead of file, as file is not a commit type defined in our guidelines
done
LGTM 👍 Thanks @nisheksharma
Description
Implemented different search algorithms and their respective tests as follows
Fibonacci Search
Related Issue
Please don't create a Pull request without creating an issue first
Fixes #23
Type of Change:
Code/Quality Assurance Only
Motivation and Context
How Has This Been Tested?
Unittest
Checklist:
Screenshots (if appropriate):