codesankalp / dsalgo

MIT License
8 stars 24 forks source link

Implemented search algorithms and their test #73

Closed devta108 closed 3 years ago

devta108 commented 3 years ago

Description

Implemented different search algorithms and their respective tests as follows

  1. Linear Search
  2. Binary Search
  3. Jump Search
  4. Interpolation Search
  5. Fibonacci Search

Related Issue

Please don't create a Pull request without creating an issue first

Fixes #23

Type of Change:

Code/Quality Assurance Only

Motivation and Context

How Has This Been Tested?

Unittest

Checklist:

Screenshots (if appropriate):

codesankalp commented 3 years ago

also this branch have conflicts so rebase your branch with master, try to squash commit into one

codesankalp commented 3 years ago

@nisheksharma after 2 days if you don't change anything then it will be marked as invalid.

devta108 commented 3 years ago

@codesankalp review

codesankalp commented 3 years ago

@Aryamanz29 @17sushmita please review this pr.

devkapilbansal commented 3 years ago

Also, please follow commit message guidelines

devkapilbansal commented 3 years ago

Pinging @17sushmita for testing code locally before merge

devkapilbansal commented 3 years ago

Thanks @nisheksharma just one last request from my side. Change type to feature instead of file, as file is not a commit type defined in our guidelines

devta108 commented 3 years ago

@nisheksharma rename your file to test_search

Done

devta108 commented 3 years ago

Thanks @nisheksharma just one last request from my side. Change type to feature instead of file, as file is not a commit type defined in our guidelines

done

devkapilbansal commented 3 years ago

LGTM 👍 Thanks @nisheksharma