codesankalp / dsalgo

MIT License
8 stars 24 forks source link

Added insert_start function for Doubly Linked List #78

Closed dennis-pg closed 3 years ago

dennis-pg commented 3 years ago

Description

Addressing Issue #77 Added required insert_start function

Related Issue

Please don't create a Pull request without creating an issue first

Fixes #77

Type of Change:

How Has This Been Tested?

Sanity checks ran

Checklist:

Screenshots (if appropriate):

devkapilbansal commented 3 years ago

@dennis-pg add test cases for this too

devkapilbansal commented 3 years ago

Also, @dennis-pg there are some more issues open related to it which are not assigned. Solve those too.

dennis-pg commented 3 years ago

Okay, will have a look

keshavgbpecdelhi commented 3 years ago

@dennis-pg, I have made some changes in your code. Feel free to squash them if you want

codesankalp commented 3 years ago

@dennis-pg are you still working on this issue?

dennis-pg commented 3 years ago

Sorry, got a bit caught up. Will finish up on this today

dennis-pg commented 3 years ago

Could you mention the issue numbers. Don't see any unresolved issues pertaining to doubly linked lists

dennis-pg commented 3 years ago

Have made the required changes

codesankalp commented 3 years ago

Please squash your commits. I will review your code after that @dennis-pg

dennis-pg commented 3 years ago

Squashed

codesankalp commented 3 years ago

@dennis-pg I see there are many commits please make them into one (squash in one commit).

dennis-pg commented 3 years ago

Done

devkapilbansal commented 3 years ago

@dennis-pg I will review and test your PR soon. Till then please follow the commit guidelines mentioned in the contribution guide.

codesankalp commented 3 years ago

image Also changed the styling because at someplace it is in the wrong format. Tested OK.

Merging.