search

codesbiome / soil-theme-vscode

A relaxing dark theme for Visual Studio Code with simple colors for the Editor Interface. This theme provides easy to read interface for dim-light environments (night).
Other
2 stars 1 forks source link

selection "invisible" inside textbox #7

Closed Miosame closed 4 years ago

Miosame commented 4 years ago

Selecting pieces of text inside textboxes very slightly alters the text, not clearly distinguishing what's selected, maybe it would be good to change it to an orange/brownish color like the selected item in the omnibar? :smile:

Here is selected text as of now: image

and here's the orange'ish color mentioned: image

codesbiome commented 4 years ago

That's a good idea Miosame, how about this color for the selection of text in textarea?

image

Miosame commented 4 years ago

@codesbiome yep that's exactly what I was thinking, for theme consistency :smile:

codesbiome commented 4 years ago

Thanks miosame, changes are added dd8e8f7836f1190a466b47e68c3c3544f8e2a2b7 Just published the theme extension with all pending changes and fixes, it might take a while to reflect as an update for Visual Studio Code.

If you notice any issues, feel free to advise Cheers!

Miosame commented 4 years ago

Interestingly enough 1.1.0 is already in the store, but the selection color did not yet make it in, is that a problem with vscode market?

codesbiome commented 4 years ago

Can you tell which textbox you were mentioning in https://github.com/codesbiome/soil-theme-vscode/issues/7#issue-714423369

I notice , the changes for selection color is not applied to the textbox of Source Control - Commit Message text field here:

image

But they are applied fine for areas like Settings, Find/Replace etc:

image

Miosame commented 4 years ago

I'm usually checking these two, the sidebar textboxes (source control, market, search, ..)

image

and the omni-bar via ctrl+shift+p or ctrl+p

image

Both screenshots have the full text selected.

codesbiome commented 4 years ago

Applied some changes regarding it in commit c44dfd18256ec1adaa0f6fce6a414ff0d846a657 It applies text selection color for all areas you mentioned (source control, market, search)

Search:

image

Source Control:

image

Extension Market:

image

Omni Bar:

image

Miosame commented 4 years ago

@codesbiome was that tagged for vscode market already?

codesbiome commented 4 years ago

Yes miosame, it is published for vscode marketplace now.

Miosame commented 4 years ago

@codesbiome just noticed, the change has also be done to the monokai theme - that's why I wasn't seeing it

codesbiome commented 4 years ago

Hello Miosame, I've just pushed the changes to new minor version 506b4b15ff8f56f25ebd1434ac7f0fb2983b8f5b , along with some other changes.

Miosame commented 4 years ago

@codesbiome thanks a lot! :tada: :raised_hands: looks like it's been pushed to the store already and is working! closing this.