fix: Fixed the vacation calculate validation issue: - Githubissues

codescalers / CSHR

CRM project mainly for the HR department to manage the employees.

Apache License 2.0

1 stars 1 forks source link

fix: Fixed the vacation calculate validation issue: #473

Closed Mahmoud-Emad closed 4 months ago

Mahmoud-Emad commented 4 months ago

Changes

Raised a value error if the end date is higher than the start date.
Return the error to the user.
Updated the UI to do the request only if everything is valid.
Updated the calculate_times function.

Related Issues

https://github.com/codescalers/CSHR/issues/472

Checklist

[ ] Tests included
[ ] Build pass
[ ] Documentation
[ ] Code format and docstrings
[ ] Screenshots/Video attached (needed for UI changes)