Support offices page - Githubissues

codescalers / CSHR

CRM project mainly for the HR department to manage the employees.

Apache License 2.0

1 stars 1 forks source link

Support offices page #509

Closed Mahmoud-Emad closed 1 month ago

Mahmoud-Emad commented 3 months ago

Description

This feat is a part of https://github.com/codescalers/CSHR/issues/433#issuecomment-2213415297

Changes

Reorder the SideBar
Created a new component to serve 404 requests
Created a new component to serve the office view
Request to load the office holidays based on the selected day
Implement a new endpoint to list office holidays
Support pagination to list paginated offices

Related Issues

https://github.com/codescalers/CSHR/issues/441

Screenshots

Checklist

[ ] Tests included
[ ] Build pass
[ ] Documentation
[ ] Code format and docstrings
[ ] Screenshots/Video attached (needed for UI changes)

zaelgohary commented 2 months ago

I navigated to wrong route and 404 page did not show. 404 route should be added to the router.

zaelgohary commented 2 months ago

We started using CSHR in 2024 and have no data prior to this year. Do we still need to show empty data for the past four years? I suggest removing them.

I also don't think we need the line Filtering the total public holidays based on the year 2024. as it's self-explanatory that filtering will be done based on the chosen year.

Maybe we can add a margin left to Egypt Office to be aligned with the rest of the content?

public holidays needs to be capitalized as well.

Mahmoud-Emad commented 1 month ago

I navigated to wrong route and 404 page did not show. 404 route should be added to the router.

Please open an issue to support this

Mahmoud-Emad commented 1 month ago

We started using CSHR in 2024 and have no data prior to this year. Do we still need to show empty data for the past four years? I suggest removing them.

I also don't think we need the line Filtering the total public holidays based on the year 2024. as it's self-explanatory that filtering will be done based on the chosen year.

Maybe we can add a margin left to Egypt Office to be aligned with the rest of the content?

public holidays needs to be capitalized as well.

The idea about the first point is something like future planning, now we return to the last 5 years, yeah we don't have data now but think about it what will happen next year? and the year after it as well and so on.
Removed
Removed the card title since we have an alert with the needed info, so it doesn't matter to have the card title component
Done