search

codescene-oss / codescene-vscode

VS Code extension providing CodeScene analysis functionality.
Other
19 stars 3 forks source link

Files not given CodeScene score #72

Closed jamieh-sky closed 2 months ago

jamieh-sky commented 3 months ago

Hi,

It has been noticed that a few files are not given a CodeScene score even though other files of the same class type and in the same directory do. 2024-07-25_12h27_10 2024-07-25_12h27_21 2024-07-25_12h27_29 2024-07-25_12h27_38

Is there any reason why some files might not be given a score?

VSCode: Version: 1.91.1 (user setup) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:06:49.809Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0.22631

VSCode Ext version: v0.7.7

adamtornhill commented 3 months ago

Thanks for reaching out, @jamieh-sky. Code Health is a metric for application code. Could it be that the unscored files only contain declarations (e.g. event handlers)? That is, there aren't any methods in them?

jamieh-sky commented 2 months ago

Hi, sorry I didn't get any alerts that this had been picked up.

@anderbergpeter & @adamtornhill the files mentioned all have methods within them

adamtornhill commented 2 months ago

@jamieh-sky Sorry for the late reply here. We'll prioritize this issue. To do so, we would need a bit more context. Would it be possible to share a little bit of the code with us via a secure and private channel? Please reach out via email: help (at) codescene.com

jlindbergh commented 2 months ago

Hi @jamieh-sky ! In order to avoid reviewing minified files (like javascript bundles) we have a maximum line length limitation. Any file containing excessively long lines will be ignored by the reviewer. There should be a warning message in the CodeScene Log about that, but we'll improve the UX for that in an upcoming release - making it more clear when this happens and what could be done about it.

jamieh-sky commented 2 months ago

Hi @jlindbergh,

Thanks for the quick response. I broke up the troublesome line and the Code Health score was generated, I also did some clicking around and found the CodeScene Log which should hopefully mean we can catch these issues earlier.

It would be a handy feature to have a more visible message on the UI when something like this happens. We will look forward to the next release!

Thanks again