search

codescene-oss / codescene-vscode

VS Code extension providing CodeScene analysis functionality.
Other
19 stars 3 forks source link

fix(code-health-monitor): Stable handling of multiple subsequent refactorings #89

Closed jlindbergh closed 3 weeks ago

jlindbergh commented 3 weeks ago

Problem

When applying a refactoring we want to make sure that that same refactoring isn't still usable.

Solution

Make sure to invalidate current refactorings for a file when applying a refactoring.

This is to prevent accidentally applying the same refactoring twice. Instead it makes sense to invalidate and await a new review+delta analysis of the updated file to get the code-health-monitor re-populated with other possible refactoring suggestions.

This commit also moves some of the functionality used by the refactoring panel into the refactoring/commands module.