search

codeschool-projects / CodeBreakerProject

Code Breaker: Challenge Friends with a Game Written using Javascript
https://codeschool-projects.github.io/CodeBreakerProject/
MIT License
26 stars 1.03k forks source link

test-fix #22

Closed KrekoG closed 7 years ago

KrekoG commented 7 years ago

The original test empties the class list of the code element it is testing, then checks for the ' failure' string. This gives a false negative result if the coder creates their solution using jQuery, as jQuery does not add the space unless there is another class already present.

With this fix, both vanilla and jQuery solutions would be tested correctly.

KrekoG commented 7 years ago

@EricJFisher Hi there, I created this PR to fix an issue described above. Can I expect an action to be taken in the close future or should I close it?

EricJFisher commented 7 years ago

My apologies for overlooking this, I'll look into your pull request as soon as I can.

EricJFisher commented 7 years ago

Okay, checked it out and looks good, sorry again for this being overlooked.