Node Structure Change: Add variant to module node of create virtual table statement.

codeschool / sqlite-parser

JavaScript implentation of SQLite 3 query parser

MIT License

331 stars 57 forks source link

Node Structure Change: Add variant to module node of create virtual table statement. #37

Closed jdrew1303 closed 8 years ago

jdrew1303 commented 8 years ago

I found another node on my travels that needs some extra fields. This isn't too urgent, Ive a work around I'm using at the moment for some of the nodes.

nwronski commented 8 years ago

Originally, I tried to create the AST to contain the minimum amount of information required. So, if there was only one node that had a type of module then I wouldn't add a variant property since that would be redundant information. But, I see more value in keeping things consistent now, so that tools like yours can be made without having to handle tons of edge cases.