codesenberg / bombardier

Fast cross-platform HTTP benchmarking tool written in Go
MIT License
6k stars 313 forks source link

Add option to set maxConcurrentStreams with http2 #66

Open sebastienros opened 4 years ago

sebastienros commented 4 years ago

I couldn't find a way to change the value of maxConcurrentStreams when using http2, and it seems it uses the default of 1000 based on this line:

https://github.com/codesenberg/bombardier/blob/ba2c55f7f39b198f98a7ce5833e84ae8608ffcea/vendor/golang.org/x/net/http2/transport.go#L483

Would it make sense to add such an option?

codesenberg commented 3 years ago

It seems like now there's an option for this in Transport: link Feel free to send a PR, if you're interested in adding this functionality.