search

codesenberg / bombardier

Fast cross-platform HTTP benchmarking tool written in Go
MIT License
5.91k stars 313 forks source link

incorrect computation of stddev? #95

Closed RobertHenry6bev closed 1 year ago

RobertHenry6bev commented 1 year ago

https://github.com/codesenberg/bombardier/blob/6b8035ac74d3b4fd39a6db980a20ba5ac2ce49dc/internal/test_info.go#L177

Per https://www.geeksforgeeks.org/python-statistics-stdev/ shouldn't the numerator read (float(count64)-1) ?

codesenberg commented 1 year ago

I guess using Bessel's correction here wouldn't hurt. Though, for larger request counts (if request count > 75 the bias is below 1%) using uncorrected sample deviation should be acceptable.