codeship-library / google-cloud-utilities

Docker images and scripts to deploy to Google Cloud
MIT License
25 stars 20 forks source link

Docker is no longer installed #49

Open LandonSchropp opened 5 years ago

LandonSchropp commented 5 years ago

I'm following up here from a support ticket we submitted to CodeShip. Recently, it seems Docker has been removed from this image. In the ticket, we asked if it was possible to add Docker ack in.

Here's was Drew's reply to our ticket:

Moving forward, we're aiming to keep the images as lean as possible here. Nothing to preclude you from building off the base image as you've recently done. Apologies again for the trouble with the update.

I'd like to respectfully request you guys reconsider this policy. Anyone who's deploying to GKE is going to need Docker installed in their image, and I'd bet that's a large group of people. Our deployment scripts depend on docker being present, and this change broke them unexpectedly.

Yes, we could extend the image and install our own tools. However, one of the biggest benefits of using CodeShip for us is that we don't have to maintain our own images—we can pull in a standard CodeShip image and run deploy with minimal effort. Pulling Docker out creates a distributed maintenance cost for anyone who wants to use these images and needs Docker.

Could you elaborate a little more on why you're striving for lean images? Is it an infrastructure cost issue? Is it due to performance? When it comes to deployment, my team's preference is for functionality. We use docker and kubectl extensively in our deployments, and we'd prefer to have those tools within arms reach by default.

Thanks for taking the time to consider.