search

codeship / codeship-tool-examples

Examples to get you started using Codeship Pro. Download the local CLI to follow along with these examples locally.
http://bit.ly/codeship-jet-tool
MIT License
52 stars 31 forks source link

Adding CI support for examples #23

Closed bfosberry closed 8 years ago

mlocher commented 8 years ago

I updated the project at https://codeship.com/projects/103513 to use @bfosberry's GitHub authentication, so we should see PR status from now on.

mlocher commented 8 years ago

Is there any way for us to use the services and steps files from the examples directly and not having to duplicate all the information into the top level codeship-services.yaml and codeship-steps.yaml files? I fear that they will get out of sync otherwise.

Should we add the top level codeship.aes and the tmp folder to .gitignore? (The key is required to run the build locally, the tmp folder will be created when running the build.)

And what about missing examples (e.g. 06, do we have plans to add those as well)

Other than that, awesome work and :shipit:

bfosberry commented 8 years ago

There is currently no way to use child steps and services files, we should add the key and tmp, and 6 looks like it runs for me, what do you see?

mlocher commented 8 years ago

You're right, example 6 is running fine, I didn't see that it was using the containers from example 5.

Examples 12 and 13 don't exist (which is what I was going to ask next, as I mostly looked at the services and steps file).

All the rest is :+1:

bfosberry commented 8 years ago

Not sure why those examples dont exist :P

mlocher commented 8 years ago

:shipit: