Closed bfosberry closed 9 years ago
Small comment, you don't have to address it. LGTM.
Amended commit to update dockerfile, also managed to stick in an if/else to check for presence of before/after scripts. I was having trouble with this before due to syntax issues in the makefile. Without it, however, the overall build was failing so make test would always error due to some examples not having before/after scripts and the associated return code.
LGTM
Depends on #3
One of the larger changes in this is adding before/after scripts to be called around the steps. This is needed for docker push to run a private registry throughout the step executions. Alternatively we could request dockerhub/quay credentials to via env or otherwise, however this method requires no initial setup from the user.