search

codeship / codeship-tool-examples

Examples to get you started using Codeship Pro. Download the local CLI to follow along with these examples locally.
http://bit.ly/codeship-jet-tool
MIT License
52 stars 31 forks source link

97197622 adding docker push example #4

Closed bfosberry closed 9 years ago

bfosberry commented 9 years ago

Depends on #3

One of the larger changes in this is adding before/after scripts to be called around the steps. This is needed for docker push to run a private registry throughout the step executions. Alternatively we could request dockerhub/quay credentials to via env or otherwise, however this method requires no initial setup from the user.

ngauthier commented 9 years ago

Small comment, you don't have to address it. LGTM.

bfosberry commented 9 years ago

Amended commit to update dockerfile, also managed to stick in an if/else to check for presence of before/after scripts. I was having trouble with this before due to syntax issues in the makefile. Without it, however, the overall build was failing so make test would always error due to some examples not having before/after scripts and the associated return code.

ngauthier commented 9 years ago

LGTM