search

codeship / scripts

Scripts for use on Codeship Basic
https://codeship.com
MIT License
217 stars 172 forks source link

Allow QPDF to still build on older versions #263

Closed Skipants closed 4 years ago

Skipants commented 5 years ago

The build steps for the QPDF package currently fail if you supply a QPDF_VERSION below 7. This checks the given version and selects the appropriate steps for each.

joesiewert commented 5 years ago

Thanks for the PR. Which version are you trying to use? I tried testing 6 and seems like there might be some other dependencies needed. Is including --enable-doc-maintenance a requirement for you as well?

Skipants commented 5 years ago

We used this script successfully with version 5.1.1 and 8.3.0. I think we might have been on 6 as well at some point, but I can't remember or find any proof of it; unfortunately we didn't keep our project settings in source control. Which version did you test with? I might just have to tweak which major (and possibly minor) version the conditional is set to.

I'm not totally sure if --enable-doc-maintenance was a strict requirement for 5.1.1, but I didn't want to try and fix what wasn't broken.

joesiewert commented 5 years ago

When trying with 5.1.1 I'm getting:

configure: WARNING: docbook fo stylesheets are required to build PDF documentation
configure: WARNING: docbook xhmtl stylesheets are required to build HTML documentation

Not sure which packages are needed here.