search

codesnake / linux-amlogic-old

Linux kernel from Amlogic
Other
28 stars 36 forks source link

new misc driver interface for amlogic cec #19

Closed gdachs closed 9 years ago

gdachs commented 9 years ago

@codesnake: now as a pull request

codesnake commented 9 years ago

I checked and unfortunately it doesn't work well. CEC stops working after a while. Original author of the patch also mentions this problem: http://forum.odroid.com/viewtopic.php?f=111&t=7540&start=150#p79142. See p9.

gdachs commented 9 years ago

Yes, but it is not the fault of the patch. The patch helps to investigate it.

codesnake commented 9 years ago

Amlogics HDMI CEC implementation works without problems for me.

gdachs commented 9 years ago

We discussed this already. What is working? I can't see how I am able to power on TV/AVR with Amlogics HDMI CEC implementation. Can you show me how?

codesnake commented 9 years ago

With your patch even button presses on TVs remote don't work.

codesnake commented 9 years ago

And after applying you patch Kodi sometimes hangs on splash screen during a boot.

gdachs commented 9 years ago

Without the patch only the remote is working. I have thought it is better to find an error in existing code, instead of living with missing functionality, but of course you are free not to use the patch.

codesnake commented 9 years ago

Yes, I agree that Amlogics HDMI CEC implementation has a lot of problems, but your implementation currently works even worse. People use HDMI CEC not to only turn on/off the TV. Believe me I don't have nothing against you patch, but in current state it is not usable. I'll be glad to merge the PR after the issues will be fixed.

gdachs commented 9 years ago

I am not a kernel hacker and have not enough time to do that, we should stop this now. Sorry for wasting your time. Had hoped it would be a faster solution for the problem.

codesnake commented 9 years ago

I struggled with your patch for a whole day, hoping to find a solution for the problem. But unfortunately currently I don't have an idea why it doesn't work.

gdachs commented 9 years ago

thanks for trying!

codesnake commented 9 years ago

np. you are welcome.

Hedda commented 9 years ago

@codesnake @gdachs optimally CEC should really not even be implemented into the Linux kernel at all, but userspace instead. see discussion with opdenkamp (libcec author) comments about LibCEC and the "HDMI CEC framework" for the Linux kernel here:

https://github.com/Pulse-Eight/libcec/issues/67

However if they insist that it is implement into the Linux kernel then the suggested "HDMI CEC framework" might be better than previous implementations.

http://lists.freedesktop.org/archives/dri-devel/2015-March/079678.html http://lists.freedesktop.org/archives/dri-devel/2015-March/thread.html#79678

But maybe better to utilize Pulse-Eight new platform support library (supported by libCEC 2.3) as a shared platform abstraction between Amlogic CEC driver for LibCEC to add Kodi / XBMC support, see

https://github.com/Pulse-Eight/libcec/pull/65 https://github.com/Pulse-Eight/platform