search

codespell-project / actions-codespell

MIT License
74 stars 19 forks source link

fix: run on node16 #51

Closed edwardgronroos closed 2 years ago

edwardgronroos commented 2 years ago

Since node-12 is now unsupported, GitHub will run all actions on node-16 instead. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Using this action currently gives this warning: image

edwardgronroos commented 2 years ago

My mistake, where a bit too quick pointing here. We're using the codespell action directly, but where referencing the hash right before the action upgrade one.

Will create PRs for the matchers and update the submodule in this one.

peternewman commented 2 years ago

We're using the codespell action directly, but where referencing the hash right before the action upgrade one.

Can I ask why if you don't mind?

Will create PRs for the matchers and update the submodule in this one.

Thanks, much appreciated!

edwardgronroos commented 2 years ago

We are whitelisting all actions by SHA instead of tags/version from security perspective. Guess on the time of whitelisting that it where the latest available version.

The reference to the submodule upstream got lost when I forked, so couldn't assist on updating it and thus closed this PR.

Thanks for a great action that saved med from shipping many typos 😅