search

codespell-project / actions-codespell

MIT License
74 stars 19 forks source link

feat: bump to use node20 runtime #71

Closed kbdharun closed 6 months ago

kbdharun commented 1 year ago

Description:

Node12 was deleted from the runner recently. And Node 16 reaches the end of life soon on 11 Sep 2023. This PR updates the default runtime to node20 (Node 20). ~I have also bumped the actions/checkout version to v4 for the same. (https://github.com/actions/runner/pull/2732)~

A major version bump might be needed after the PRs merge.

cclauss commented 6 months ago

Mostly a duplicate of the Dependabot automated:

Please rebase so we can land the important change to codespell-problem-matcher/action.yml.

DimitriPapadopoulos commented 6 months ago

I tried to rebase, but unfortunately a new error appeared: enabling pre-commit for all repositories without creating a .pre-commit-config.yaml file for each directory was an error.

kbdharun commented 6 months ago

Thanks for rebasing @DimitriPapadopoulos . Just now, noticed the previous comment.

Updated the PR title for the same.

DimitriPapadopoulos commented 6 months ago

Could you create a minimal .pre-commit-config.yaml to pass tests? I don't have rights to merge pull requests that don't pass tests.

kbdharun commented 6 months ago

Could you create a minimal .pre-commit-config.yaml to pass tests? I don't have rights to merge pull requests that don't pass tests.

Merged changes from #75 for this.

DimitriPapadopoulos commented 6 months ago

@peternewman @larsoner Could you have a look and merge this?

larsoner commented 6 months ago

Thanks @kbdharun @cclauss !