search

codespell-project / codespell

check code for common misspellings
GNU General Public License v2.0
1.81k stars 465 forks source link

Add reusing misspelling and variants #3445

Closed korverdev closed 1 month ago

korverdev commented 1 month ago

This contains the same changes as https://github.com/codespell-project/codespell/pull/3443. Creating a second PR to get around the incorrect code coverage check the prior PR was failing.

DimitriPapadopoulos commented 1 month ago

View this Pull Request on Codecov

87.35% (-1.23%) compared to https://github.com/codespell-project/codespell/commit/383a32cceb44d2841f3a3c7e418fc4a18f9a3f37

Something's very wrong, 383a32cceb44d2841f3a3c7e418fc4a18f9a3f37 is an old commit from last January. Why does Codecov compare to 383a32cceb44d2841f3a3c7e418fc4a18f9a3f37?

DimitriPapadopoulos commented 1 month ago

All I can think of is that intermediate coverage reports have somehow been lost.

DimitriPapadopoulos commented 1 month ago

@larsoner Based on "How to prevent codecov from using a commit older than the base of the PR to do comparison?" I suspect there is no way to convince Codecov to compare with the last commit instead of 383a32c, probably because intermediate coverage data has been lost somehow. If so, the only solution is to "change the status checks to be informational until the repository stabilizes".

larsoner commented 1 month ago

Let's see if it stabilizes soon... in theory it should only take one commit, so maybe after a couple Codecov will figure things out. If not then yes we can change to informative