search

codespell-project / codespell

check code for common misspellings
GNU General Public License v2.0
1.81k stars 465 forks source link

MAINT: Fix codecov #3451

Closed larsoner closed 1 month ago

larsoner commented 1 month ago

v4 of the action requires a token for main branch uploads (but not PRs, which is why those still work!), see e.g.

https://github.com/codespell-project/codespell/actions/runs/9456240994/job/26047760545#step:9:38 https://docs.codecov.com/docs/quick-start#step-2-get-the-repository-upload-token

DimitriPapadopoulos commented 1 month ago

I understand the GitHub action requires secrets.CODECOV_TOKEN to update coverage reports, doesn't it? From the v4.0.0 breaking changes:

Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.

What I don't fully understand is why this bites us now: we upgraded to @v4 in #3066 / 63b4568, on 5 September 2023. I presume the coverage reports have not been updated since. But then, why does Codecov insist on comparing to #3347 / 383a32c from 31 January 2024, more than 4 months later?

Anyway, I hope this resets the GitHub action. Let's merge and try.

larsoner commented 1 month ago

Yes I already added the token, let's see if things are fixed