Open corneliusroemer opened 2 months ago
I've added tests because codecov failed otherwise. Not sure these are super important but what's done is done! Learned something about testing on the way - and mocking!
I am happy with codecov failing on exceptions, but I don't have rights to merge when CI tests fail. With that said, adding tests looks like the best option.
Indeed, I will make an issue there if I remember
On Tue, Aug 20, 2024, 09:50 Dimitri Papadopoulos Orfanos < @.***> wrote:
@.**** commented on this pull request.
In codespell_lib/_codespell.py https://github.com/codespell-project/codespell/pull/3524#discussion_r1722852956 :
- return lines, f.encoding
- return lines, encoding
Indeed. The chardet documentation should describe the return values in more detail.
— Reply to this email directly, view it on GitHub https://github.com/codespell-project/codespell/pull/3524#discussion_r1722852956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF77AQNAITVX26F5UWGKDP3ZSLYM5AVCNFSM6AAAAABMWRLYDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBXGIZDSNBYG4 . You are receiving this because you authored the thread.Message ID: @.***>
resolves #3519
Tested and it works now, reporting the file name: