Add missing conversions between host and device byte order

codestation / vitamtp

Library to interact with Vita's USB MTP protocol (No longer maintained)

GNU General Public License v3.0

32 stars 28 forks source link

Add missing conversions between host and device byte order #5

Closed zeldin closed 8 years ago

zeldin commented 9 years ago

Hi. I tried to get qcma running on Linux/PPC, but noticed that the conversions between host and device byte order were missing in all the Vita-specific parts of VitaMTP (they were done correctly in the generic PTP code). So I fixed it for you. :smiley: I hardcoded the device endianness as little in order to avoid a dependency on PTPParams; if Sony ever releases a big endian Vita it should be straightforward enough to refactor this...

codestation commented 9 years ago

Since i don't have any PPC device the most that i can do is to test that this change doesn't break on current Linux/Win32/Win64 builds. I will merge this after i get some free time to do the testing.

zeldin commented 9 years ago

Thanks. I have the opposite problem that I can't test on Windows, so some testing there would definitely be useful...

Also, great job on making this!

codestation commented 8 years ago

Merged on 0e4309d8ba86134418d612cb78cea8e9cbd75fb1