search

codesuki / ecs-gen

docker-gen for AWS ECS
MIT License
48 stars 21 forks source link

Support for Labels #10

Open simplesteph opened 7 years ago

simplesteph commented 7 years ago

It seems that docker-gen as of 0.4.0 supports placing some variables in labels instead of environment variables, which is a bit cleaner.

https://github.com/jwilder/nginx-proxy/issues/172#issuecomment-107810833

Thoughts on implementing this? I could try doing a PR at some point

codesuki commented 7 years ago

If you want to do that you have to read about docker labels here: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html

We can access those parameters.

For me it would be low priority because it works fine with environment variables for now. I would prefer to add path (instead of domain) mapping and authentication first.