codesuki / react-d3-components

D3 Components for React
http://codesuki.github.io/react-d3-components/example.html
MIT License
1.63k stars 206 forks source link

Change the render order of the Axes in LineChart #107

Closed krosenberg closed 7 years ago

krosenberg commented 7 years ago

In the LineChart component, the Axes should render before the DataSet so that axis tick paths (if configured to span across the chart) don't cover up any paths rendered by the DataSet. This change will also make the render order consistent with the ScatterPlot component, in which Axes are rendered first. This affects the look/aesthetics of the graph, but also affects tooltip rendering; a tick line intersecting a point on the graph will cause the tooltip to hide if the cursor is placed on the tick line rather than the data line. screen shot 2016-08-22 at 11 08 14 am

codesuki commented 7 years ago

Good catch! Thanks a lot for taking the time to send a pullreq.