search

codesuki / react-d3-components

D3 Components for React
http://codesuki.github.io/react-d3-components/example.html
MIT License
1.63k stars 205 forks source link

Change render order of Axes in BarChart #125

Closed peterssonjonas closed 7 years ago

peterssonjonas commented 7 years ago

By rendering the axes first, tick lines will not cover the bars.

I see that some of the graphs (e.g ScatterPlot, LineChart) renders the Axes first and then the actual Dataset, but for the BarChart this is not the case.

I don't know if the current approach is on purpose, but I would like to add tick lines that do not cover the bars.

Currently:

screen shot 2017-02-11 at 11 56 03

What I want:

screen shot 2017-02-11 at 11 57 31
codesuki commented 7 years ago

Oh wow! I never used that so it never came up. Of course the one you proposed looks correct and this is a bug/oversight. Would you consider sending a pullreq for that? The earliest I can change it is beginning of next week.

codesuki commented 7 years ago

Released in 0.6.6 Thanks again!