Mixin -> HOC + ES6 classes - Githubissues

codesuki / react-d3-components

D3 Components for React

http://codesuki.github.io/react-d3-components/example.html

MIT License

1.63k stars 206 forks source link

Mixin -> HOC + ES6 classes #160

Closed retyui closed 5 years ago

retyui commented 6 years ago

Replaced mixin to hocs
Removed react-create-call, Instead, ES classes are used.
Added support new React Refs API

the only difference from the version with myxins that the colors of the fill are different

retyui commented 6 years ago

https://github.com/codesuki/react-d3-components/issues/120 | https://github.com/codesuki/react-d3-components/issues/133

@codesuki You can create a branch for development? Where I could send all the changes from this PR and future changes: TODO:

[x] Replace deprecated Mixins to HOCs
[x] Overwrite components to ES classes
[ ] To cover the code with tests
[ ] Add typescript type decloaration https://github.com/codesuki/react-d3-components/issues/103 | first commints
[ ] Update d3 to latest version https://github.com/codesuki/react-d3-components/issues/155
[ ] Improve performance https://github.com/codesuki/react-d3-components/issues/23 | https://github.com/codesuki/react-d3-components/issues/105
[ ] Update README

codesuki commented 6 years ago

Sorry for the long delay. I made a branch for you: https://github.com/codesuki/react-d3-components/tree/development Good job so far!

retyui commented 6 years ago

@codesuki Now I'm finishing the tests. And after that you can check PR

codesuki commented 5 years ago

Let me know when I should review!