search

codetaylor / dropt-1.12

Flexible block drop strategies.
https://minecraft.curseforge.com/projects/dropt
Other
6 stars 2 forks source link

Harvester blacklist on held item both matches and does not match. #61

Closed therealpygon closed 5 years ago

therealpygon commented 5 years ago

I think there are a couple logic issues in the HeldItemMatcher checkAsBlacklist() code.

I believe the issues are:

https://github.com/codetaylor/dropt/blob/6c24c93b343d48ea0e84d7b613967170d3c635d3/src/main/java/com/codetaylor/mc/dropt/modules/dropt/rule/match/HeldItemMatcher.java#L243

Should continue if not matched (L251), rather than matched(L243).

https://github.com/codetaylor/dropt/blob/6c24c93b343d48ea0e84d7b613967170d3c635d3/src/main/java/com/codetaylor/mc/dropt/modules/dropt/rule/match/HeldItemMatcher.java#L287

Should return false if not tags because item matched blacklist.

codetaylor commented 5 years ago

Additional info from Discord:

image

codetaylor commented 5 years ago

Thanks for the report!

Yeah, there was some junk logic in there. Looks like it was introduced in 1.16.0 with the NBT matching stuff. I'm fairly certain I've fixed it in 1.16.1