codetaylor / dropt-1.12

Flexible block drop strategies.
https://minecraft.curseforge.com/projects/dropt
Other
6 stars 2 forks source link

Mod support for explosion harvesting #68

Closed CelestialPhoenix closed 4 years ago

CelestialPhoenix commented 4 years ago

Issue Description

Some explosives from mods don't work with the explosion harvester (I think they use a different explosion handler??) (Such as Immersive Engineering and IndustrialCraft). (the block drops its standard drop instead of the explosive drop specified in the script) Would it be possible to add support for those mods please?

Script The script itself works perfectly fine with Vanilla TNT, and a some modded explosives. https://github.com/CelestialPhoenix/BS-G-1.12-Pack/blob/master/scripts/Block%20Drops/Taint.zs#L50

Affected Versions

codetaylor commented 4 years ago

For these mods to work with Dropt, they must fire these events in the following order:

  1. ExplosionEvent.Detonate
  2. BlockEvent.BreakEvent

IE does not do this: https://github.com/BluSunrize/ImmersiveEngineering/blob/f2334410de60bc8e8d65ad2921f58e9fe37e784c/src/main/java/blusunrize/immersiveengineering/common/blocks/wooden/BlockWoodenDevice0.java#L84

I didn't look at IC2, but I assume it's not firing the events.