codetaylor / pyrotech-1.12

An early game mod with new primitive devices, combustion machines, smelting mechanics, storage options, tools, torches, advancements, and absolutely zero GUIs -- with exception to the substantially complete, mostly illustrated, and charred guidebook.
https://pyrotech.readthedocs.io/en/latest/
Other
52 stars 19 forks source link

Spacing typo on second page of bloomery in guide book #168

Open DWX12 opened 5 years ago

DWX12 commented 5 years ago

Issue Description

There is a spacing typo in the guidebook in the second page of the bloomer description: "...with averified fire-starter device." Two spaces after with and a verified being put together as one word.

Affected Versions

codetaylor commented 5 years ago

Looks fine on my end. What version of Patchouli are you on?

[...] then ignite the top with a $(l:appendix/ignition)verified fire-starter device$().

image

DWX12 commented 5 years ago

I'm using Patchouli-1.0-20, which, as of this moment, is the current version available. Next time I'm able to, I'll readd Pyrotech and see about grabbing a screenshot of the error if it is still present.

codetaylor commented 5 years ago

I was building against 1.0-19.94, but just updated to 1.0-20.108 and tested. Still looks fine on my end.

DWX12 commented 5 years ago

2019-08-23_18 43 49

codetaylor commented 5 years ago

Yeah, I see it. Still can't reproduce it.

My best guess at this point is that it's a Patchouli rendering thing. The spacing displays correctly for me in all resolution / Patchouli book size combinations. The spacing is also correct in the json file.

image

Have you tried other Patchouli book resolutions?

DWX12 commented 5 years ago

Once I have some more time I will try other resolutions and sizes with Patchouli. I'm just wondering why this is happening or what is causing it on my end. Very strange.

I do use Optifine and run Minecraft at the large video setting.

DWX12 commented 5 years ago

I'm running pyrotech-1.12.2-1.3.8 and forge-1.12.2-14.23.5.2834-universal.

Just tested changing of both the gui size in Patchouli and in Minecraft general settings and neither made any impact upon the problem. I guess for now it will be an unresolved issue on my end then. No clue as to what's happening or what's causing it, but if it's not present in anyone elses, than I'm not going to worry about it.

Thanks for taking a look though.

hron84 commented 5 years ago

@DWX12 I recommend you to remove OptiFine, it causes a lot of rendering issues in a wide variety of mods. Optifine is fine for vanilla, but in the modded world, causes more issues than it solves.

For making better graphical performance, consider using BetterFPS and FoamFix which are a replacement for OptiFine in this specific situation. They do not support shaders, and AFAIK there is currently no mature mod for shaders.