search

codetaylor / pyrotech-1.12

An early game mod with new primitive devices, combustion machines, smelting mechanics, storage options, tools, torches, advancements, and absolutely zero GUIs -- with exception to the substantially complete, mostly illustrated, and charred guidebook.
https://pyrotech.readthedocs.io/en/latest/
Other
52 stars 20 forks source link

Combining items doesn't make an outcome #252

Closed jamesreii closed 4 years ago

jamesreii commented 4 years ago

Issue Description

[Currently, combining items in a worktable doesn't create an outcome unless using a crafting table or GUI crafting grid]

What Happens

[When combining resources in a worktable, particularly potions [Combined Potions Mod] and liners with armour [Armour Underwear Mod], once hammered, the items disappear and doesn't seem to make the combined item]

What You Expect to Happen

[I would expect that the item would appear in my inventory but it just disappears]

Affected Versions

katubug commented 4 years ago

I popped by to report something different and came across this issue, and decided to test, since I am also using some of those mods. I can confirm that this occurs when applying the liners from ArmorUnderwear. I note that it does not affect all recipes from the mod - I was able to craft the actual liners, it was just when trying to apply the liners to armor that the recipe completes but does not output a finished item of any kind.

Minecraft: 1.12.2 Forge: 2847 Armor Underwear: 1.0.0 CarrotsLib: 1.0.0b1 Pyrotech: 1.4.16 Athenaeum: 1.17.4 Dropt: 1.16.1

Here's an excerpt from the latest.log, in which I attempted to apply one of each type of liner to its respective Diamond armor counterpart.

[18:04:25] [Server thread/INFO]: <Katubug> this is a placeholder
[18:04:25] [Client thread/INFO]: [CHAT] <Katubug> this is a placeholder
[18:04:30] [Client thread/INFO]: [CHAT] Set player temperature to 12
[18:04:33] [Server thread/WARN]: Potentially Dangerous alternative prefix `armorunder` for name `lined_helmet_1layer_cool`, expected `pyrotech`. This could be a intended override, but in most cases indicates a broken mod.
[18:04:47] [Server thread/WARN]: Potentially Dangerous alternative prefix `armorunder` for name `optional/antifreeze_lined_leggings`, expected `pyrotech`. This could be a intended override, but in most cases indicates a broken mod.
[18:04:53] [Server thread/WARN]: Potentially Dangerous alternative prefix `armorunder` for name `optional/obsidian_lined_boots`, expected `pyrotech`. This could be a intended override, but in most cases indicates a broken mod.
[18:04:58] [Server thread/INFO]: <Katubug> and done
[18:04:58] [Client thread/INFO]: [CHAT] <Katubug> and done

Let me know if you'd like me to get you any other information on this!

katubug commented 4 years ago

I had some more free time, so here's a full latest.log: https://pastebin.com/YsDSnzFG

I created an isolated instance with the following mods/versions:

Loaded up the game with no configs generated, created a new creative world, and exited the game. Loaded back up and entered the same world. Gave myself both worktables, a diamond hammer, and 3 matching pieces of diamond armor and Armor Underwear liners (one cooling, one warming, one auto-regulating). Changed mode to survival (previous tests were in creative), and did 1 recipe on the wooden Workbench and 2 on the Stone Workbench. All 3 tests consumed the items and did not provide an output.

I've never seen the "potentially dangerous prefix" error outside of initialization, so I'm guessing that's related, but I'm not sure how. In any case, hope this helps!

codetaylor commented 4 years ago

I was able to reproduce this using the vanilla dye + leather armor recipe.

codetaylor commented 4 years ago

image

It should be fixed in the next patch version. Waila doesn't respect the item's NBT data when rendering the item, but afaik that's a Waila issue.

katubug commented 4 years ago

Update, using the build you linked in discord -

latest.log: https://pastebin.com/BhpNBKvB

Tests were conducted on the wooden Workbench.

Testing a second time, with the ArmorUnder liner limit increased from 3 to 8.

I did a third test with the ArmorUnder config increased from 8 to 99, and it still only allows 3 applications, so that part is just an issue on their end. But in terms of this bug, it seems it now allows the items to be "worked" on the workbench, even if there isn't a valid recipe output.