search

codetaylor / pyrotech-1.12

An early game mod with new primitive devices, combustion machines, smelting mechanics, storage options, tools, torches, advancements, and absolutely zero GUIs -- with exception to the substantially complete, mostly illustrated, and charred guidebook.
https://pyrotech.readthedocs.io/en/latest/
Other
52 stars 19 forks source link

Bloomery compat #304

Closed CactusDuud closed 4 years ago

CactusDuud commented 4 years ago

Issue Description

When using JAOPCA Ore Chunks ores generated by that mod (ore chunks from JAOPCA) don't work with the bloomery, with the weird exception of vanilla ores and silver for some odd reason. When looking at the custom ore list to change it myself, I realised the unlocalised names are used to register ores instead of registry names. Unfortunately JAOPCA's unlocalised names are all the same due to its auto-generated nature. Ideally an option to use registry names would be included.

What Happens

Bloomery won't accept ore chunks as ores, except gold, iron, and silver.

What You Expect to Happen

The ability to smelt other ores too.

Script

No ct script, but the auto-generated ore list can be found here

Crash Log

None

Affected Versions

codetaylor commented 4 years ago

the unlocalised names are used to register ores instead of registry names

Not sure what you mean here. The lang keys are only used to display in tooltips. You could provide your own lang key and reference your own lang file provided with ResourceLoader or you could just write in a name like "Unobtanium Ore" and it would use that.

Pyrotech uses the oredict to generate compat. You can read more about how it works here: https://pyrotech.readthedocs.io/en/latest/orecompat/

CactusDuud commented 4 years ago

Ah apologies I totally misread. Even still, I'm unable to use JAOPCA ore chunks in the bloomery, even though I have ores like oreLead that are in the auto-generated list. Should I just add them to the bloomery manually?

codetaylor commented 4 years ago

No worries. Ensure that the entries that you want to use are in the core.compat.Ore-Custom.json file. That's the one that is read and used by Pyrotech. The core.compat.Ore-Generated.json is overwritten on each load with the mod's generated stuff, but it's up to you to move any of that stuff into the custom file.

CactusDuud commented 4 years ago

Ahh I see. Thank you so much!