Torches don't ignite on client (but are lit on the server)

codetaylor / pyrotech-1.12

An early game mod with new primitive devices, combustion machines, smelting mechanics, storage options, tools, torches, advancements, and absolutely zero GUIs -- with exception to the substantially complete, mostly illustrated, and charred guidebook.

https://pyrotech.readthedocs.io/en/latest/

Other

52 stars 19 forks source link

Torches don't ignite on client (but are lit on the server) #333

Closed yaroslav4167 closed 3 years ago

yaroslav4167 commented 3 years ago

Issue Description

I update pyrotech on my server to version 1.12.2-1.5.2 (earlier I had version 1.12.2-1.4.22). And torch_fiber / torch_stone stopped lighting up.

Video reproduce

In singleplayer torches work fine.

Affected Versions

Minecraft: 1.12.2
Forge: 1.12.2-14.23.5.2847
CraftTweaker: 1.12-4.1.20.586
Dropt: 1.12.2-1.18.0
Pyrotech: 1.12.2-1.5.2
Athenaeum: 1.12.2-1.19.2
SpongeForge: 7.3.1-RC4093

codetaylor commented 3 years ago

Thanks for the report!

All blockstate changes are encoded to meta values when transmitted to the client. Since I forgot to override the methods for blockstate encoding in the torch block, the server was always sending the default state of UNLIT regardless of the actual state on the server.

This is fixed in 1.12.2-1.5.3

yaroslav4167 commented 3 years ago

I tested this commit. Torches lighting fine. but all torches are installed vertically only. J30lDVy8Il

codetaylor commented 3 years ago

That is a separate, but likely related issue.