search

codetaylor / pyrotech-1.12

An early game mod with new primitive devices, combustion machines, smelting mechanics, storage options, tools, torches, advancements, and absolutely zero GUIs -- with exception to the substantially complete, mostly illustrated, and charred guidebook.
https://pyrotech.readthedocs.io/en/latest/
Other
52 stars 19 forks source link

Bellows cause fuel burn time to become offset from recipe duration #339

Open ghost opened 3 years ago

ghost commented 3 years ago

Issue Description

Using the bellows with a stone kiln (and stone oven) causes a slight discrepancy between fuel burn time and recipe duration.

What Happens

I have my installation of pyrotech configured so that the amount of time it takes for ores to be smelted in the kiln (using crafttweaker to create recipes, set durations, etc.) exactly matches the burn time of two pieces of coal.

When using the kiln without bellows, this works as expected: The recipe finishes at the exact same time that fuel runs out.

However, if I use the bellows, the recipe time and burn time will desync slightly from one another by varying amounts and in either direction.

If I use exactly two coal (with my configuration options) while using the bellows, much of the time the fuel will run out while the recipe still has one or sometimes two seconds remaining.

What You Expect to Happen

I would expect the recipe duration and burn time to remain synchronized.

Script

N/A

Crash Log

N/A

Affected Versions

codetaylor commented 3 years ago

It's likely due to the accumulation of many, many floating point rounding errors. It wasn't designed with the goal of precision.