search

codetaylor / pyrotech-1.12

An early game mod with new primitive devices, combustion machines, smelting mechanics, storage options, tools, torches, advancements, and absolutely zero GUIs -- with exception to the substantially complete, mostly illustrated, and charred guidebook.
https://pyrotech.readthedocs.io/en/latest/
Other
52 stars 20 forks source link

Make Bloomery recipe & WitherForgeRecipe public #441

Open juraj-hrivnak opened 3 months ago

juraj-hrivnak commented 3 months ago

Hello, I understand why these constructors are package-private since you should use the recipe builders. Yet, the reason for making these constructors public is to provide compatibility for the GroovyScript mod to add these recipes using its recipe builders. All the best, teksturepako

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

codetaylor commented 3 months ago

I'm not entirely convinced this is the right solution for the problem. The builders assert certain conditions which are then assumed by the rest of the code. Exposing the constructors directly places the responsibility of those assertions into the user domain, which invalidates the assumptions.

Is there no way to use the provided builders with the GroovyScript mod?