search

codetaylor / pyrotech-1.12

An early game mod with new primitive devices, combustion machines, smelting mechanics, storage options, tools, torches, advancements, and absolutely zero GUIs -- with exception to the substantially complete, mostly illustrated, and charred guidebook.
https://pyrotech.readthedocs.io/en/latest/
Other
52 stars 20 forks source link

Worktable grabbing recipes from Thaumcraft 6 #80

Open Noxalas opened 5 years ago

Noxalas commented 5 years ago

Hey there!

Pyrotech's worktable is grabbing recipes from the Arcane Workbench in Thaumcraft 6, resulting in the recipes not costing any Vis or crystals.

codetaylor commented 5 years ago

I am not familiar with Thaumcraft. Can you please provide steps to reproduce this?

codetaylor commented 5 years ago

Nevermind, I think I got it.

This is happening because Thaumcraft uses the vanilla crafting recipe registry for its arcane recipes which, imho, it shouldn't do. JEI shows the arcane recipes are craftable in both the vanilla crafting table and Pyrotech's worktable because neither JEI nor Pyrotech filter the vanilla crafting registry to specifically exclude Thaumcraft's arcane recipes.

It doesn't appear that the arcane recipes are actually craftable in either the vanilla crafting table or Pyrotech's worktable.

2019-06-27_15-51-07

Noxalas commented 5 years ago

Ah, I see! My bad for not actually checking if the items are craftable. Thank you so much. Love this mod and what you're doing with it, keep up the amazing work.

codetaylor commented 5 years ago

I could probably filter out the arcane recipes from the worktable recipes in JEI, but I don't think I can do anything about the arcane recipes being displayed for the vanilla crafting.

Primitive-Human commented 4 days ago

I've just noticed this issue as well and of course looked in existing issues before making my own.

Would it help if I disabled the vanilla recipe inheritance and re-added the recipes to PT's worktables? It's a workaround but I'm making custom recipes either way.

codetaylor commented 4 days ago

I think so. I'd have to try it to be sure.