codethesaurus / codethesaur.us

A polyglot developer reference tool to compare programming language concepts side-by-side! Great for learning new languages or using for reference.
https://codethesaur.us
GNU Affero General Public License v3.0
289 stars 170 forks source link

Fix Reference lookups aren't logged in database in views.py #724

Closed Frederic-Chopin closed 4 months ago

Frederic-Chopin commented 6 months ago

What GitHub issue does this PR apply to?

Resolves #723

What changed and why?

- Fixed issue where reference page lookups were not being stored in the database.

(If editing Django app) Please add screenshots

Checklist

Any additional comments or things to be aware of while reviewing?

tested locally and now reference page lookup is stored in the web_lookupdata table in the database

geekygirlsarah commented 6 months ago

Such a simple fix! I told myself I'd go dig after work and you beat me to it!

How would you feel about making some unit tests that call the compare and reference pages and ensure it logs a visit? (You can say no since it's easy to call the page but checking the storage of it is a bit more complicated.)

Frederic-Chopin commented 5 months ago

Hi Sarah, sure, I can try adding some unit tests over the weekend!

geekygirlsarah commented 4 months ago

@Frederic-Chopin Are you still working on this? If not, I can merge and maybe split off the tests as another issue. Let me know!

Frederic-Chopin commented 4 months ago

Hi Sarah, sorry for the late reply. I think it's best to split the test as another issue, thank you !

geekygirlsarah commented 4 months ago

I made #725 for it. If you want to work on that, go claim it. If not, I may get to it soon.

Thanks for working on this! I'll merge it in.