Closed Frederic-Chopin closed 4 months ago
Such a simple fix! I told myself I'd go dig after work and you beat me to it!
How would you feel about making some unit tests that call the compare and reference pages and ensure it logs a visit? (You can say no since it's easy to call the page but checking the storage of it is a bit more complicated.)
Hi Sarah, sure, I can try adding some unit tests over the weekend!
@Frederic-Chopin Are you still working on this? If not, I can merge and maybe split off the tests as another issue. Let me know!
Hi Sarah, sorry for the late reply. I think it's best to split the test as another issue, thank you !
I made #725 for it. If you want to work on that, go claim it. If not, I may get to it soon.
Thanks for working on this! I'll merge it in.
What GitHub issue does this PR apply to?
Resolves #723
What changed and why?
concepts
function inviews.py
to callstore_lookup_info
even when only one language is present.(If editing Django app) Please add screenshots
Checklist
Any additional comments or things to be aware of while reviewing?
tested locally and now reference page lookup is stored in the web_lookupdata table in the database