Add language CLIPS, add structures Facts and Rules to CLIPS 6.4.1

codethesaurus / codethesaur.us

A polyglot developer reference tool to compare programming language concepts side-by-side! Great for learning new languages or using for reference.

https://codethesaur.us

GNU Affero General Public License v3.0

289 stars 170 forks source link

Add language CLIPS, add structures Facts and Rules to CLIPS 6.4.1 #744

Closed mrryanjohnston closed 1 month ago

mrryanjohnston commented 3 months ago

What GitHub issue does this PR apply to?

Resolves #743

What changed and why?

I added the CLIPS programming language, as well as 2 structures and 4 concepts.

Checklist

[x] I claimed any associated issue(s) and they are not someone else's
[x] I have looked at documentation to ensure I made any revisions correctly
[ ] I tested my changes locally to ensure they work
[ ] For language files, I have validated the edited files are valid JSON and data shows up correctly
[ ] For website code edits, I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

Is there an automated way to test my changes?

geekygirlsarah commented 3 months ago

I started writing a comment on another computer and forgot to send!

Is there an automated way to test my changes?

There's a few ways of varying amounts of "automated":

Run the validate commands (python manage.py validatemetainfofile and python manage.py validatelanginfofiles, same things run on PRs)
Run the Docker container with the site and test it there to see if results are what you expect
Install and run it on your computer and test it there to see if results are what you expect

I also noticed the contributions add new concepts (which you figured out on your own). I'll probably make some suggestions to help them match some styles we have on other concept files.

geekygirlsarah commented 3 months ago

So the tl;dr of my not merging yet is that it crashes when trying to look up this change. It's not the fault of this, and I made issue #746 for this. So it'll have to wait to get merged until that's resolved!

mrryanjohnston commented 3 months ago

So the tl;dr of my not merging yet is that it crashes when trying to look up this change. It's not the fault of this, and I made issue #746 for this. So it'll have to wait to get merged until that's resolved!

No rush :) let me know if I can help

geekygirlsarah commented 1 month ago

I think #751 fixed the bug on #746 to make this work! I can merge it in now. Thanks for adding to this!

I think since this was created before October it doesn't count towards Hacktoberfest, but this project is opted in, so if you want to keep contributing, future PRs in October would count towards the 4 PRs!