codethesaurus / codethesaur.us

A polyglot developer reference tool to compare programming language concepts side-by-side! Great for learning new languages or using for reference.
https://codethesaur.us
GNU Affero General Public License v3.0
289 stars 170 forks source link

Kotlin String Implementaiton #759

Closed apurvabanka closed 3 weeks ago

apurvabanka commented 4 weeks ago

What GitHub issue does this PR apply to?

Resolves #741

What changed and why?

Implemented changes for Kotlin String.

image

(If editing website code) Please add screenshots

Checklist

Any additional comments or things to be aware of while reviewing?

geekygirlsarah commented 3 weeks ago

From the validating checks:

Error:  `kotlin/1.5/strings.json`, ID: `count_occurrences_of_substring` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error:  `kotlin/1.5/strings.json`, ID: `convert_to_title_case` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error:  `kotlin/1.5/strings.json`, ID: `parameter_format_in_order` has not_implemented (underscore) when it should use not-implemented (hyphen)
3 errors found.

I think I also saw a "not-implemented": "true" (with quotes around true) that will need to get fixed. But past that it looks good! Fix those things and I'm happy to merge it in!

(The docker check is an issue related to a library it uses, and isn't a fault of this PR so I'm ignoring it)

apurvabanka commented 3 weeks ago

From the validating checks:

Error:  `kotlin/1.5/strings.json`, ID: `count_occurrences_of_substring` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error:  `kotlin/1.5/strings.json`, ID: `convert_to_title_case` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error:  `kotlin/1.5/strings.json`, ID: `parameter_format_in_order` has not_implemented (underscore) when it should use not-implemented (hyphen)
3 errors found.

I think I also saw a "not-implemented": "true" (with quotes around true) that will need to get fixed. But past that it looks good! Fix those things and I'm happy to merge it in!

(The docker check is an issue related to a library it uses, and isn't a fault of this PR so I'm ignoring it)

My bad !!!! Fixed it.

geekygirlsarah commented 3 weeks ago

From the validating checks:

Error:  `kotlin/1.5/strings.json`, ID: `count_occurrences_of_substring` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error:  `kotlin/1.5/strings.json`, ID: `convert_to_title_case` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error:  `kotlin/1.5/strings.json`, ID: `parameter_format_in_order` has not_implemented (underscore) when it should use not-implemented (hyphen)
3 errors found.

Those still need to be fixed, they failed the validating check again.

apurvabanka commented 3 weeks ago

@geekygirlsarah Are there any instructions on how to run the tests?

geekygirlsarah commented 3 weeks ago

I swore we had a docs page on it, but I'm not seeing it. Either I'm tired or it doesn't exist! 😆

you can run: python manage.py validatemetainfofile to validate meta_info.json and adding a new language/concept, or python manage.py validatelanginfofiles to validate individual files (like what you're doing)

Ideally run both to get a full check on it.

geekygirlsarah commented 3 weeks ago

https://github.com/codethesaurus/docs/issues/42

Clearly I thought this through a year ago! 😆

apurvabanka commented 3 weeks ago

@geekygirlsarah Added some testing docs as well for the contribution page. All test cases are passing now.

geekygirlsarah commented 3 weeks ago

Ignoring the Docker build issue, this is good to go! I'll merge it in.

Happy Hacktoberfest! This counts towards that if you're participating!