Closed apurvabanka closed 3 weeks ago
From the validating checks:
Error: `kotlin/1.5/strings.json`, ID: `count_occurrences_of_substring` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error: `kotlin/1.5/strings.json`, ID: `convert_to_title_case` has not_implemented (underscore) when it should use not-implemented (hyphen)
Error: `kotlin/1.5/strings.json`, ID: `parameter_format_in_order` has not_implemented (underscore) when it should use not-implemented (hyphen)
3 errors found.
I think I also saw a "not-implemented": "true"
(with quotes around true) that will need to get fixed. But past that it looks good! Fix those things and I'm happy to merge it in!
(The docker check is an issue related to a library it uses, and isn't a fault of this PR so I'm ignoring it)
From the validating checks:
Error: `kotlin/1.5/strings.json`, ID: `count_occurrences_of_substring` has not_implemented (underscore) when it should use not-implemented (hyphen) Error: `kotlin/1.5/strings.json`, ID: `convert_to_title_case` has not_implemented (underscore) when it should use not-implemented (hyphen) Error: `kotlin/1.5/strings.json`, ID: `parameter_format_in_order` has not_implemented (underscore) when it should use not-implemented (hyphen) 3 errors found.
I think I also saw a
"not-implemented": "true"
(with quotes around true) that will need to get fixed. But past that it looks good! Fix those things and I'm happy to merge it in!(The docker check is an issue related to a library it uses, and isn't a fault of this PR so I'm ignoring it)
My bad !!!! Fixed it.
From the validating checks:
Error: `kotlin/1.5/strings.json`, ID: `count_occurrences_of_substring` has not_implemented (underscore) when it should use not-implemented (hyphen) Error: `kotlin/1.5/strings.json`, ID: `convert_to_title_case` has not_implemented (underscore) when it should use not-implemented (hyphen) Error: `kotlin/1.5/strings.json`, ID: `parameter_format_in_order` has not_implemented (underscore) when it should use not-implemented (hyphen) 3 errors found.
Those still need to be fixed, they failed the validating check again.
@geekygirlsarah Are there any instructions on how to run the tests?
I swore we had a docs page on it, but I'm not seeing it. Either I'm tired or it doesn't exist! 😆
you can run:
python manage.py validatemetainfofile
to validate meta_info.json and adding a new language/concept, or
python manage.py validatelanginfofiles
to validate individual files (like what you're doing)
Ideally run both to get a full check on it.
https://github.com/codethesaurus/docs/issues/42
Clearly I thought this through a year ago! 😆
@geekygirlsarah Added some testing docs as well for the contribution page. All test cases are passing now.
Ignoring the Docker build issue, this is good to go! I'll merge it in.
Happy Hacktoberfest! This counts towards that if you're participating!
What GitHub issue does this PR apply to?
Resolves #741
What changed and why?
Implemented changes for Kotlin String.
(If editing website code) Please add screenshots
Checklist
Any additional comments or things to be aware of while reviewing?