search

codetheweb / anylist

📋 a wrapper for AnyList's API (unoffical, reverse engineered)
88 stars 23 forks source link

Add Meal Planning Calendar Events #39

Closed jchadwick closed 9 months ago

jchadwick commented 10 months ago

Add support for Meal Planning Calendar Events.

NOTE: current draft PR only implements reading of existing calendar events; still working on creating/updating/deleting them.

First commit in the branch also fixes a few eslint issues that were keeping me from committing; happy to make another branch/PR for those if that helps.

jchadwick commented 10 months ago

@codetheweb seems to work pretty well so far, but would love your feedback before I go too much further.

Also, is there any value in merging this PR as read-only and then implementing the write operations in another PR, or would you rather I get it all working prior to merging?

kevdliu commented 10 months ago

Since recipes and meal planning events seem to be closely related I think it would be better to combine the getReceipes and getMealPlanningCalendarEvents functions into one. This way only one request is needed to fetch all the data for both

kevdliu commented 10 months ago

@codetheweb seems to work pretty well so far, but would love your feedback before I go too much further.

Also, is there any value in merging this PR as read-only and then implementing the write operations in another PR, or would you rather I get it all working prior to merging?

Since this PR is working I think it would be fine to merge it. It would make reviewing easier as well

jchadwick commented 9 months ago

If you're cool with merging the read-only, so am I.

But as we look at this I have another branch trying to get the write operations working. I've never used protobuf before so I'm a little out of my element. I'm looking at your code and I can see how it works but can't quite figure out how to write myself from scratch

Don't suppose you could point me in the direction of something that could help?

codetheweb commented 9 months ago

sorry for the late response, I'm fine with merging read-only for now

jchadwick commented 9 months ago

Alright, no problem - just need to resolve your change request, but I'm not sure exactly what you're looking for.

jchadwick commented 9 months ago

Since recipes and meal planning events seem to be closely related I think it would be better to combine the getReceipes and getMealPlanningCalendarEvents functions into one. This way only one request is needed to fetch all the data for both

I actually have another idea for this. I'll submit another PR once we get through this one.

jchadwick commented 9 months ago

Since recipes and meal planning events seem to be closely related I think it would be better to combine the getReceipes and getMealPlanningCalendarEvents functions into one. This way only one request is needed to fetch all the data for both

I actually have another idea for this. I'll submit another PR once we get through this one.

Here it is: #42