search

codetheweb / aoede

🎧 a self-hosted Spotify → Discord music bot
MIT License
294 stars 28 forks source link

Volume Control not working #9

Closed iKasu2k closed 2 years ago

iKasu2k commented 2 years ago

Hi & Merry Christmas! This Bot is exactly what I was looking for as a middleware for a bigger project, but I ran into a tiny tiny problem.... when trying to adjust the volume through spotify it doesn't seem to work.

Unfortunately, I'm not into rust but still went ahead and tried to rebuild the bot with initial volume for librespot and also adjusting the volume in the enable_connect function, however, it doesn't affect the bot as well. Volume remains constant.

Is there a way to adjust the initial volume of the bot?

sibartel commented 2 years ago

Heyho Kasu, in the last days I have made a few changes based on personal needs to aoede and among other things added a volume control via spotify. From your description, I didn't quite understand if you want to adjust the volume while listening or if you are only interested in configuring the initial volume. Nevertheless, you can take a look at my fork and especially this commit:

sibartel/aoede@7e45d7f490e9d786f8d9444415bc6c4a9f7ad816

There are still some things on my list which I want to tackle. After I implement these, I will also discuss with @codetheweb if he is interested in a pull request for some or all of my changes.

Best regards!

codetheweb commented 2 years ago

Yep, volume control would be nice.

@sibartel that'd be great!

Let me know when you're ready and we can discuss.

iKasu2k commented 2 years ago

@sibartel volume control via spotify was exactly what I was looking for. I thought it would be a bit more complex to implement, thus asked if it's possible to adjust initial volume.

You both saved Christmas for me, thank you very much!

codetheweb commented 2 years ago

Released in v0.3.0.