search

codetheweb / muse

🎧 a self-hosted midwestern Discord music bot that doesn't suck
MIT License
799 stars 201 forks source link

Implement volume control #830 #994

Closed FoxxMD closed 4 months ago

FoxxMD commented 5 months ago

Closes #830

github-actions[bot] commented 5 months ago

:package: A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-994 or codetheweb/muse:52d2ccba1f2bd02253e29a305b72cf95681d5b65.

Images are available for x86_64 and ARM64.

Latest commit: 52d2ccba1f2bd02253e29a305b72cf95681d5b65

FoxxMD commented 5 months ago

Er...need to make volume persistent first. Please hold.

FoxxMD commented 5 months ago

VOLUME_CONTROL was implemented because in the original issue you cited volume control as having the potential to be abused, which I agree with. Right now, even w/o the env, only guild admins can use the control.

Would you prefer to keep it this way? I'd prefer to make it accessible to admin and role-based so admins can dole out control to trusted users. I have no problem implementing that if that is ok for you. Nevermind, I forgot guilds can control command access via roles in the discord server settings ui now. I'll make the command available to everyone. :+1:

Instead of using the same /volume command for the persisted volume level I'm implementing a default volume config setting via /config set-default-volume so that the persisted value is a default for new players but the player volume itself is independent for the "listening session"

For settings in sqlite -- I see that currently each setting is a different column. I usually prefer to do a KV approach so that new settings can be added without requiring a migration. Would that be acceptable? I'll write the migrations for that as well. EX

Current Table

image

New

image

FoxxMD commented 4 months ago

I've been using this on my own server since the last change and it has been working perfectly :+1:

ghost commented 4 months ago

I would love to see this so people stop complaining about it being way to loud when they first experience the music bot.

codetheweb commented 4 months ago

looks like there's some merge conflicts, happy to take a final look and merge after they're resolved

@GitGurky in the meantime, if you're using the Docker image, feel free to switch to the image tag that the bot posted above to start using this

FoxxMD commented 4 months ago

This is ready to merge, again.

@GitGurky you should use foxxmd/muse:latest because its the latest code IE this PR merged with latest muse. codetheweb/muse:pr-994 is the PR as of feb 2 which is missing features and not up to date with db migrations.

codetheweb commented 4 months ago

codetheweb/muse:pr-994 is the PR as of feb 2 which is missing features and not up to date with db migrations.

hmm, why do you say that? going by the commit hash it seems to have the latest commit

github-actions[bot] commented 4 months ago

🚀 Released in Release v2.7.0.

FoxxMD commented 4 months ago

When I looked at the tag on dockerhub the last push was ~20 days ago. It now shows it as pushed 13 hours ago.