Open evancharlton opened 5 years ago
+1 for custom themes, or even just a couple of different theme options.
A dark theme in particular would be much appreciated.
EDIT: I've made a basic dark theme that covers most of the bases of basic display. It has some jarring transitions in hovers and a clicked issue still comes up in light theme. However, please feel free to make use of it.
EDIT2: Updated the user stylesheet on 3/26/09
@ac21 please give me the access for intercom.
AFAIK intercom is codetree's internal CRM. It looks like it's supposed to be for employees only. I've been receiving notifications about the intercom posts for a while without being able to view them. It might be better to consolidate them all in one comment with an explanation for outside people that they shouldn't expect to be able to access them.
@scottmmjackson - the notices you are getting are just +1's by other community members, except we do it on their behalf to save them the effort and to help us understand the interest in this feature. FYI, we have prioritized this issue for development, so hoping to deliver it either this sprint or next.
I understand that, I suggested that since this is a public repository, the posts be consolidated and come with an explanation, so users watching the issue don't try clicking on them and get confused as to why they can't access it. Does that make sense?
@scottmmjackson - it definitely makes sense and I can see the frustration. you proposed solution probably makes sense going forward (although we'll need to test it out to ensure the Intercom webhooks work with consolidation). thanks for the suggestion
@sachinkum123 - my iniital thoughts on implementation: 1) create some color classes with our default colors ( codetree-bg-color ) 2) migrate default color definitions out of components and into these color classes and apply classes to html (1+2 allows for use of asset pipeline and single download of common files) 3) when custom color preferences exist, overload color classes with new colors either through late loading header CSS or dynamic JS (does this make sense?) 4) provide options to specify colors in project settings (or should this be user settings? I'm torn a bit). seems like we have 4: (bg, text, accent, container) any more? 5) when specifying colors, you can choose the default, dark, or custom (where users can key in RBG codes) 6) cache dark or custom color preferences (in session key/redis for speed), reduce db hits thoughts?
needs codetree/codetree#2239
Background
It would be great if Codetree officially supported different themes. You don't have to build them, just use stable CSS class names. Maybe an option to allow admins to upload their own additional stylesheet(s) for the org/project to use.
But again: the bare minimum of stable class names would be great -- I can fire up Stylus and take it from there.
Solution
Allow for customizable themes