I have Heroku Ci enabled, but only for people who are maintainers on the repo (I work there, I want to use a feature I maintain). However since this doesn't fire for 3rd party contributions and there's a difference between those tests and github actions tests I can merge a PR that looks like it's passing but it fails on Heroku:
-----> Running test command `bundle exec rubocop && bin/rails test && rails db:seed`...
Inspecting 265 files
.........................................................................................................................................................................................................................................................................
265 files inspected, no offenses detected
[Scout] [10/28/23 13:40:57 +0000 test.7766 (1381)] INFO : Scout Agent [5.3.1] Initialized
[Scout] [10/28/23 13:40:57 +0000 test.7766 (1381)] INFO : Not Loading Instruments
[Scout] [10/28/23 13:40:57 +0000 test.7766 (1381)] INFO : Scout Agent [5.3.1] Installed
[Scout] [10/28/23 13:40:57 +0000 test.7766 (1381)] INFO : Monitoring isn't enabled for the [test] environment.
[Scout] [10/28/23 13:40:57 +0000 test.7766 (1381)] INFO : Deferring agent start. Standing by for first request
Run options: --seed 45381
# Running:
...............................Cloning into 'get_process_mem'...
E
Error:
ParseDocsTest#test_Does_not_error:
LoadError: cannot load such file -- yard
lib/docs_doctor/parsers/ruby/yard.rb:90:in `process'
app/models/repo.rb:74:in `populate_docs!'
test/jobs/parse_docs_test.rb:23:in `block in <class:ParseDocsTest>'
rails test test/jobs/parse_docs_test.rb:21
.E
Error:
ParseDocsTest#test_Can_parse_yard_docs:
LoadError: cannot load such file -- yard
lib/docs_doctor/parsers/ruby/yard.rb:90:in `process'
test/jobs/parse_docs_test.rb:13:in `block in <class:ParseDocsTest>'
rails test test/jobs/parse_docs_test.rb:6
.................................................................................................................................................................................
Finished in 9.658808s, 21.8453 runs/s, 41.8271 assertions/s.
211 runs, 404 assertions, 0 failures, 2 errors, 0 skips
Coverage report generated for Minitest to /app/coverage. 5066 / 10954 LOC (46.25%) covered.
-----> test command `bundle exec rubocop && bin/rails test && rails db:seed` failed with exit status 1
The tests pass here, but rails db:seed fails. So I guess I'm asking someone to add rails db:seed to github actions to verify it works.
I have Heroku Ci enabled, but only for people who are maintainers on the repo (I work there, I want to use a feature I maintain). However since this doesn't fire for 3rd party contributions and there's a difference between those tests and github actions tests I can merge a PR that looks like it's passing but it fails on Heroku:
The tests pass here, but
rails db:seedfails. So I guess I'm asking someone to addrails db:seedto github actions to verify it works.