search

codetriage / docs_doctor

http://docsdoctor.org
27 stars 21 forks source link

Add commit sha to repo #40

Closed kddnewton closed 8 years ago

kddnewton commented 8 years ago

Store the commit sha of the time the repo was last processed. Ensures the emails point to the correct location in source. Fixes issue #39.

schneems commented 8 years ago

thanks!

kddnewton commented 8 years ago

Just need to make sure to run the process! before the next release so commit_sha gets populated. @schneems

schneems commented 8 years ago

Just got a link to https://github.com/rails/rails/blob/a7379ce9efb01fb3cd6d9cf6b09b698995377d5a/actionpack/lib/action_dispatch/http/response.rb/#L310 but it is supposed to be ActionDispatch::Response#merge_default_headers but instead it is

Any ideas?

kddnewton commented 8 years ago

@schneems Yeah some of the links that I'm getting are right and some of them are off. Any chance that between the time the git clone is executed and the sha is saved there's a delay? Rails gets stuff merged pretty quickly.

Also, interestingly, all of my ruby repo links are correct, but the rails ones are not.

kddnewton commented 8 years ago

@schneems After some further investigation, that file hasn't been updated in a while, so my initial theory can't be right. I'll do some more investigation after work today.