codeuino / codebadge-backend

GNU General Public License v3.0
15 stars 23 forks source link

Added backend for the Codebadge project #54

Closed ayushnagar123 closed 4 years ago

ayushnagar123 commented 4 years ago

Problem

Github Issue Number: #53 #51

PR includes:

Type of Change

Checklist

jaskiratsingh2000 commented 4 years ago

Good

On Sat, 6 Jun 2020, 6:46 am Ayush Nagar, notifications@github.com wrote:

Problem

Github Issue Number: #53 https://github.com/codeuino/codebadge-backend/issues/53 PR includes:

  • login
  • signup
  • fetching user details
  • fetching organization details
  • fetching organization members

Type of Change

  • Bug fix
  • New Feature
  • Development of UI/UX prototypes
  • Small refactor
  • Change in Documentation

Checklist

  • My code follows the same style as the codebase
  • My Code change requires a change in documentation
  • I have updated the Readme accordingly
  • I made PR against development branch
  • I have run the test cases locally and it's passing.
  • I have squashed my commits

You can view, comment on, or merge this pull request online at:

https://github.com/codeuino/codebadge-backend/pull/54 Commit Summary

  • back and frontend integrated till member and user profile fetch
  • typo bugs fixed
  • Create LICENSE

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/codeuino/codebadge-backend/pull/54, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOBHK7JOG6RWCMBESOWGILRVGKFXANCNFSM4NVNHITQ .

devesh-verma commented 4 years ago
  1. @ayushnagar123 Going ahead I would like to see PRs more often. It's hard to review 92file changes in 1PR. Also, it's not preferred keeping in consideration the commit history and progress of the project.
  2. Make 1PR per functionality.
  3. Also, work on your commit messages.
  4. Squash your commits.

TL;DR I am okay reviewing more PRs rather than reviewing 1PR with so much of work.

ayushnagar123 commented 4 years ago

Surely i will take care of it next time thanks for the inputs.

ayushnagar123 commented 4 years ago

I have updated and created a new pull request #55