codeuino / social-platform-donut-backend

Donut API:
http://donut-api-prod.codeuino.org/
GNU General Public License v3.0
24 stars 57 forks source link

Adding the http-status-codes (npm depencency) for handling the status of the API #112

Open tanujvyas10 opened 4 years ago

tanujvyas10 commented 4 years ago

Current scenario Currently ,the backend is using the custom made http status code.

Expected solution Backend should be using the npm dependency http-status-codes for status handling of an API

Additional context @devesh-verma @jaskirat2000 @vaibhavdaren If the issue is valid, I would like to work on this

Rupeshiya commented 4 years ago

@tanujvyas10 Why to be dependent on other API or dependencies when you know the values of status codes?? let say we are going to use that, then can you please tell me the benefit of this npm package??

tanujvyas10 commented 4 years ago

Hey @rupeshiya I admire your concern See, of course, we can create our own custom made functionality not for status code but for everything but since our backend is proportionally using npm dependencies so why not use the one that majorly used in many standard nodejs projects. The benefit of using it is to make the code base more standardize by using the pre-defined npm dependencies when needed anywhere We can just add Http-status-codes npm dependency for once and directly use it whenever any status handling is needed. Again that is my suggestion for the status handling otherwise whatever the mentors feel best for the project source code Still waiting for the mentors' point of view about this P.s thanks for taking interest in my concern fo r the following feature